Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

generation of real benchmark functions for benchmarking v2 #13224

Merged
merged 42 commits into from Feb 22, 2023
Merged

generation of real benchmark functions for benchmarking v2 #13224

merged 42 commits into from Feb 22, 2023

Commits on Feb 14, 2023

  1. function generation with _name working, need to modify signature

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    5214c62 View commit details
    Browse the repository at this point in the history

  2. WIP

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    7b84838 View commit details
    Browse the repository at this point in the history

  3. support custom BenchmarkResult<T> type

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    c7110fb View commit details
    Browse the repository at this point in the history

  4. full support for BenchmarkResult<T> on benchmark function defs

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    ebd6206 View commit details
    Browse the repository at this point in the history

  5. support () return type for benchmark function defs that don't use ?

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    80fef06 View commit details
    Browse the repository at this point in the history

  6. uncomment

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    b812762 View commit details
    Browse the repository at this point in the history

  7. fix where clause handling

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    e33b00a View commit details
    Browse the repository at this point in the history

  8. fix benchmark function call bodies

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    da30b03 View commit details
    Browse the repository at this point in the history

  9. proper parsing of return type

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    3e37c0d View commit details
    Browse the repository at this point in the history

  10. add UI tests for bad return type

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    5de194d View commit details
    Browse the repository at this point in the history

  11. fix detection of missing last_stmt with defined return type

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    a0d93dc View commit details
    Browse the repository at this point in the history

  12. UI tests covering missing last_stmt

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    4b20793 View commit details
    Browse the repository at this point in the history

  13. properly detect and complain about empty benchmark function defs

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    fc3ccfb View commit details
    Browse the repository at this point in the history

  14. fix missing Comma in Result<T, BenchmarkError> parsing + test

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    d409eda View commit details
    Browse the repository at this point in the history

  15. add additional UI test

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    37f986b View commit details
    Browse the repository at this point in the history

  16. allow complex path for BenchmarkResult and BenchmarkError in fn defs

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    fe4f234 View commit details
    Browse the repository at this point in the history

  17. add UI tests covering complex path for BenchmarkResult, BenchmarkError

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    a773e7f View commit details
    Browse the repository at this point in the history

  18. retain doc comments and attributes

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    1261327 View commit details
    Browse the repository at this point in the history

  19. also add attributes to struct

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    a2c2274 View commit details
    Browse the repository at this point in the history

  20. add docs for benchmark function definition support

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    550f97a View commit details
    Browse the repository at this point in the history

  21. fix imports on benchmark example

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    4c41f4e View commit details
    Browse the repository at this point in the history

  22. fix issue with unused variables in extrinsic call fn def

    @sam0x17
    sam0x17 committed Feb 14, 2023
    Copy the full SHA
    4e6bcb9 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. fix up docs

    @sam0x17
    sam0x17 committed Feb 15, 2023
    Copy the full SHA
    9c10c4c View commit details
    Browse the repository at this point in the history

  2. remove support for v2::BenchmarkResult because it was confusing

    @sam0x17
    sam0x17 committed Feb 15, 2023
    Copy the full SHA
    2ff8eda View commit details
    Browse the repository at this point in the history

  3. fix typo

    @sam0x17
    sam0x17 committed Feb 15, 2023
    Copy the full SHA
    460ed3c View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. remove ability to use custom T for Result<T, BenchmarkError> in v2

    @sam0x17
    sam0x17 committed Feb 17, 2023
    Copy the full SHA
    16f2e4c View commit details
    Browse the repository at this point in the history

  2. use missing call error instead of empty_fn()

    @sam0x17
    sam0x17 committed Feb 17, 2023
    Copy the full SHA
    14de958 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. remove unneeded match statement

    @sam0x17
    sam0x17 committed Feb 18, 2023
    Copy the full SHA
    db8a68a View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Add a proper QED 

    Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
    @sam0x17 @KiChjang
    sam0x17 and KiChjang committed Feb 20, 2023
    Copy the full SHA
    edd3dd7 View commit details
    Browse the repository at this point in the history

  2. fix other QED 

    Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
    @sam0x17 @KiChjang
    sam0x17 and KiChjang committed Feb 20, 2023
    Copy the full SHA
    da10ba1 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. cargo fmt

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    d8b2e8c View commit details
    Browse the repository at this point in the history

  2. add an explicit error for non TypePath as return type

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    1e74d11 View commit details
    Browse the repository at this point in the history

  3. tweak error warning and add a UI test for non TypePath return

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    b3bdbd6 View commit details
    Browse the repository at this point in the history

  4. remove comment

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    20bf0fc View commit details
    Browse the repository at this point in the history

  5. add docs about T and I generic params

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    ef739b2 View commit details
    Browse the repository at this point in the history

  6. improve docs referring to section "below"

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    0ce80e1 View commit details
    Browse the repository at this point in the history

  7. pull out return type checking logic into its own function

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    46e6883 View commit details
    Browse the repository at this point in the history

  8. pull out params parsing into its own function

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    27df864 View commit details
    Browse the repository at this point in the history

  9. pull out call_def parsing into its own function

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    fb05d87 View commit details
    Browse the repository at this point in the history

  10. add doc comment for missing_call()

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    abe495b View commit details
    Browse the repository at this point in the history

  11. replace spaces with tabs

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    de6cc9d View commit details
    Browse the repository at this point in the history

  12. add a result-based example to the benchmarking examples

    @sam0x17
    sam0x17 committed Feb 21, 2023
    Copy the full SHA
    60e9841 View commit details
    Browse the repository at this point in the history