Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

store nomination pools total value locked on-chain #13319

Closed
wants to merge 1 commit into from

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Feb 6, 2023

could resolve paritytech/polkadot-sdk#440 as well.

  • fix tests
  • migration (initialize the TVL storage value for existing nomination pools)
  • new invariant (try-state function to check the storage TVL does not diverge from actual TVL)
  • safe math

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Feb 6, 2023
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2357655

@stale
Copy link

stale bot commented Mar 8, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added A3-stale and removed A3-stale labels Mar 8, 2023
@stale
Copy link

stale bot commented Apr 16, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Apr 16, 2023
@stale stale bot closed this May 1, 2023
@liamaharon
Copy link
Member

Not at the top of my TODO list, but plan to getting around to it in the next couple of weeks.

@liamaharon liamaharon reopened this May 3, 2023
@stale stale bot removed the A3-stale label May 3, 2023
@stale
Copy link

stale bot commented Jun 8, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Jun 8, 2023
@stale stale bot removed the A3-stale label Jun 12, 2023
@stale
Copy link

stale bot commented Jul 12, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Jul 12, 2023
@liamaharon liamaharon changed the title track total value locked in pools onchain track total value locked in nomination pools onchain Jul 12, 2023
@stale stale bot removed the A3-stale label Jul 12, 2023
@liamaharon liamaharon changed the title track total value locked in nomination pools onchain store nomination pools total value locked on-chain Jul 12, 2023
@liamaharon
Copy link
Member

I plan to get around this next month, but in case someone wants to beat me to it I created a mentor issue: paritytech/polkadot-sdk#155

@stale
Copy link

stale bot commented Aug 11, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Aug 11, 2023
@kianenigma
Copy link
Contributor Author

Closing in favor of #14775

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. A3-stale
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Mark nomination-pool funds as deactivated
3 participants