Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update documentation for uniques (This PR renames classes and instances to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) #13322

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

simonsso
Copy link
Contributor

@simonsso simonsso commented Feb 7, 2023

The documentation was outdated after merge of #11389

Using the widely spread term collections and item instead of the previous class and instance.

The documentation was outdated after merge of paritytech#11389
Using the widely spread term collections and item instead
of the previous class and instance.
@simonsso simonsso changed the title Update documentation for uniques Update documentation for uniques (This PR renames classes and instances to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) Feb 7, 2023
@ggwpez ggwpez added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit C1-low labels Feb 7, 2023
@jsidorenko
Copy link
Contributor

Doesn't the phrase an asset item look weird?
I would suggest checking the Readme file of the new NFTs pallet and taking the copy from here. https://github.com/paritytech/substrate/blob/master/frame/nfts/README.md

@simonsso
Copy link
Contributor Author

simonsso commented Feb 9, 2023

Doesn't the phrase an asset item look weird?

Ehh maybe ... looks ok to me but I am (1) a software developer and (2) not a native speaker, so anyone who masters the art of writing for humans may help.

@the-right-joyce the-right-joyce added C1-low PR touches the given topic and has a low impact on builders. and removed C1-low labels Feb 13, 2023
@stale
Copy link

stale bot commented Mar 16, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Mar 16, 2023
@stale stale bot removed the A3-stale label Mar 16, 2023
@jsidorenko
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for a4b00a9

@jsidorenko
Copy link
Contributor

@simonsso could you pls merge master into your branch?

@jsidorenko
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 1f09739 into paritytech:master Apr 4, 2023
gpestana pushed a commit that referenced this pull request Apr 23, 2023
…es to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) (#13322)

* Update documentation for uniques

The documentation was outdated after merge of #11389
Using the widely spread term collections and item instead
of the previous class and instance.

* Update README.md

---------

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
Co-authored-by: Jegor Sidorenko <jegor@parity.io>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…es to collections and items in the Uniques pallet in order to follow the commonly accepted NFTs terminology.) (paritytech#13322)

* Update documentation for uniques

The documentation was outdated after merge of paritytech#11389
Using the widely spread term collections and item instead
of the previous class and instance.

* Update README.md

---------

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
Co-authored-by: Jegor Sidorenko <jegor@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants