This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make pallet_nfts storages public #13517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsidorenko Could you help to take a look? (don't know how to assign reviewers...) |
dmitry-markin
added
A0-please_review
jsidorenko
approved these changes
Mar 9, 2023
shawntabrizi
approved these changes
Mar 9, 2023
|
bot merge |
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
I'm trying to build a pallet to work with pallet_nft,
my goal is disable most of pallet_nfts extrinsic and my pallet will help to management collection, minting nfts and update them, users can only own and burn, rest of other operations are limited.
my first try is using nonfungibles_v2 traits but meet some trouble (I make a PR #13514 ), but I don't know how to construct ItemId so I'm stuck.
here's second try, I'm letting my pallet extending pallet_nft (
pub trait Config<I: 'static = ()>: frame_system::Config + pallet_nfts::Config<I>), so I can access pallet_nft directly, and most of functions are public so I can call them, however, some of arguments require read from storage (e.g.collection_id) are restricted bypub(super)so I can't access them.But still, ItemId is hard to construct... any advice?
this PR make them public.