Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

contracts: Follow up for benchmark simplification #13635

Merged
merged 4 commits into from
Mar 21, 2023
Merged

contracts: Follow up for benchmark simplification #13635

merged 4 commits into from
Mar 21, 2023

Conversation

athei
Copy link
Member

@athei athei commented Mar 19, 2023

  • Rename *_BENCHMARK_BATCHES to *_BENCHMARK_RUNS as batches are no longer a concept
  • Reduce the amount of runs for slow benchmarks

Do not merge until we ran the benchmarks here. Only run benchmarks after #13312 is merged to avoid conflicts.

@athei athei added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 19, 2023
@athei athei mentioned this pull request Mar 19, 2023
Merged
@athei
Copy link
Member Author

athei commented Mar 21, 2023

bot clean
bot bench $ pallet dev pallet_contracts

@command-bot
Copy link

command-bot bot commented Mar 21, 2023 •
edited
Loading

@athei https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2558127 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 116-1bf1e15c-af33-4206-b16f-86932c843102 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 21, 2023

@athei Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2558127 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2558127/artifacts/download.

@athei athei merged commit 859bb12 into master Mar 21, 2023
@athei athei deleted the at/rename-batches branch March 21, 2023 09:46
breathx pushed a commit to gear-tech/substrate that referenced this pull request Apr 22, 2023
@athei @breathx
contracts: Follow up for benchmark simplification (paritytech#13635)
d75db45 
* Rename BATCHES -> RUNS

* Reduce runs of slow benchmarks

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts

---------

Co-authored-by: command-bot <>
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@athei @nathanwhit
contracts: Follow up for benchmark simplification (paritytech#13635)
7ffd365 
* Rename BATCHES -> RUNS

* Reduce runs of slow benchmarks

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts

---------

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agryaznov agryaznov agryaznov approved these changes

@xermicus xermicus xermicus approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Smart Contracts
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@athei @agryaznov @xermicus