This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Various minor fixes #13945
Merged
Various minor fixes #13945
+98
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
KiChjang
reviewed
Apr 19, 2023
| @@ -784,7 +784,7 @@ pub mod pallet { | |||
| return false | |||
| } | |||
| a.flags.set_new_logic(); | |||
| if !a.reserved.is_zero() || !a.frozen.is_zero() { | |||
| if !a.reserved.is_zero() && a.frozen.is_zero() { | |||
There was a problem hiding this comment.
This logic here is essentially saying that frozen funds don't contribute any provider refs; is this true?
There was a problem hiding this comment.
Well, it's that frozen funds already require a consumer ref in the original logic, so if we have non-zero frozen funds, then we already have the consumer we need (and if we have a consumer, we must have a provider).
There was a problem hiding this comment.
Ah ok, so it's reserved funds in the old logic that did not have a consumer, and so we have to add it here?
ggwpez
approved these changes
Apr 19, 2023
KiChjang
reviewed
Apr 19, 2023
KiChjang
approved these changes
Apr 20, 2023
sam0x17
approved these changes
Apr 20, 2023
kianenigma
approved these changes
Apr 20, 2023
jakoblell
added
D1-audited 👍
|
bot merge |
|
Error: Response error (status 500 Internal Server Error): |
1 similar comment
|
Error: Response error (status 500 Internal Server Error): |
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 26ced3c |
|
bot rebase |
|
Rebased |
|
bot merge |
|
Waiting for commit status. |
gpestana
pushed a commit
that referenced
this pull request
May 4, 2023
* Fix: Incorrect implementation of can_reserve check * Fix: Incorrect migration of consumer counting for existing accounts with frozen amounts * Fix: Inconsistent implementation between assets can_deposit and new_account * Fixes * Fixes * Another fix * Update tests.rs * Update fungible_tests.rs * Use `can_accrue_consumers` in the body of `can_inc_consumer` --------- Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: parity-processbot <>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Fix: Incorrect implementation of can_reserve check * Fix: Incorrect migration of consumer counting for existing accounts with frozen amounts * Fix: Inconsistent implementation between assets can_deposit and new_account * Fixes * Fixes * Another fix * Update tests.rs * Update fungible_tests.rs * Use `can_accrue_consumers` in the body of `can_inc_consumer` --------- Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.