Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remote ext parallel download fix #14086

Merged
merged 1 commit into from
May 7, 2023
Merged

Remote ext parallel download fix #14086

merged 1 commit into from
May 7, 2023

Conversation

Ank4n
Copy link
Contributor

@Ank4n Ank4n commented May 6, 2023

If payload length is less than parallel requests, this panics. Small fix to ensure we divide payload in at least one chunk.

@Ank4n Ank4n added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 6, 2023
@Ank4n Ank4n requested a review from liamaharon May 6, 2023 15:18
liamaharon
liamaharon approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liamaharon
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit da3821e into master May 7, 2023
@paritytech-processbot paritytech-processbot bot deleted the ank4n/fix-min-chunks branch May 7, 2023 16:06
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@Ank4n @nathanwhit
divide payload into atleast one chunk (paritytech#14086)
6a66e5f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@liamaharon liamaharon liamaharon approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ank4n @liamaharon @niklasad1