This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[fix lint warnings: NFTs pallet] fix clippy::missing_docs_in_private_items warnings #14610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 21, 2023 12:45
sacha-l
added
A2-insubstantial
added 11 commits
July 25, 2023 10:57
added 3 commits
August 14, 2023 17:22
|
bot rebase |
…-docs-private-items-lint
|
Rebased |
jsidorenko
approved these changes
Aug 15, 2023
|
bot fmt |
|
@sacha-l https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3388817 was started for your command Comment |
|
@sacha-l Command |
gilescope
reviewed
Aug 15, 2023
gilescope
reviewed
Aug 15, 2023
gilescope
reviewed
Aug 15, 2023
gilescope
reviewed
Aug 15, 2023
gilescope
reviewed
Aug 15, 2023
gilescope
reviewed
Aug 15, 2023
gilescope
approved these changes
Aug 15, 2023
Co-authored-by: Squirrel <gilescope@gmail.com>
|
bot merge |
paritytech-processbot
bot
deleted the
sl/fix-nfts-missing-docs-private-items-lint
branch
Ank4n
pushed a commit
that referenced
this pull request
Aug 20, 2023
…items warnings (#14610) * add docs for impl_codec_bitflags * add missing docs for type aliases * add docs to transfer module * add docs for settings module * add docs to roles module * add docs to metadata module * add docs to migration module * add missing docs to feature library * methods not functions * add docs to lock module * add docs to attributes module * add docs to create_delete_item module * add docs for create_delete_collection module * add docs to buy_sell module * add missing doc for buy_sell module * add docs to atomic_swap module * add docs to atomic_swap module * add docs for approvals module * run cargo fmt * Fix issues with multi-line comments * Apply suggestions from code review Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> * update from review * fmt * update from review * remove bitflag example * ".git/.scripts/commands/fmt/fmt.sh" * Apply suggestions from code review Co-authored-by: Squirrel <gilescope@gmail.com> * add note about pallet features --------- Co-authored-by: Jegor Sidorenko <jegor@parity.io> Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> Co-authored-by: parity-processbot <> Co-authored-by: Squirrel <gilescope@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the 66 warnings emitted by running
cargo clippy -- -A clippy::all -W clippy::missing_docs_in_private_items --no-depsin the NFTs pallet crate. It adds the missing docs for the pallet's helper functions and associated modules.This is part of an ongoing effort from the https://github.com/orgs/paritytech/teams/devrel team to improve developer experience.