Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improvements to system_networkState #2088

Merged
merged 2 commits into from Mar 26, 2019

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 22, 2019

Prints the state of the peerset (always null for now), and the external addresses.

@tomaka tomaka added the A0-please_review Pull request needs code review. label Mar 22, 2019
@tomaka tomaka added this to Triage in Networking (Outdated) via automation Mar 22, 2019

/// Produces a JSON object containing the state of the peerset manager, for debugging purposes.
pub fn debug_info(&self) -> serde_json::Value {
serde_json::Value::Null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug nothing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the peerset crate is a stub that will be implemented in the near future.

@gavofyork
Copy link
Member

@tomaka needs resolving.

@gavofyork gavofyork added A7-looksgoodcantmerge and removed A0-please_review Pull request needs code review. labels Mar 26, 2019
@gavofyork gavofyork merged commit fe8b33c into paritytech:master Mar 26, 2019
Networking (Outdated) automation moved this from Triage to Done Mar 26, 2019
@tomaka tomaka deleted the better-net-debug branch March 26, 2019 14:21
MTDK1 pushed a commit to bdevux/substrate that referenced this pull request Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants