Rename Hashing Trait to Hash #288
Conversation
gnunicorn
force-pushed
the
ben-rename-hashing-trait
branch
from
52c7e9f
to
fdbac97
Compare
There was a problem hiding this comment.
Naming... sigh. :)
So in a recent refactoring in parity-ethereum a Hasher trait was added with the stated goal of enabling code sharing with Polkadot (e.g. patricia_trie, memorydb and others).
I am honestly not sure what the relationship is to Hash/Hashing but they sure look very alike. Should they be unified perhaps?
|
Hi guys. I was close to committing some stuff myself. I had assigned #172 to myself, but I am new to GitHub - is there something else that I should do in future? |
|
@dvdplm not sure. This is very specific change and I am honestly not yet clear enough of all the moving parts to be able to do anything about it. @simonljs I am sorry, that is my bad, I didn't see you had assigned that to yourself, when starting it. I don't think there is much else you could/should do, as I am not aware we've defined a proper process for project management, including how tracking would work so we don't have multiple people working on the same thing (correct me if I'm wrong). Again, I am sorry for having stepped on your toes here! |
|
@gnunicorn That's ok - I'm new to the codebase so it was a useful learning exercise anyway! :) |
|
@dvdplm yes, the |
|
@rphmeier Ok, cool. @gnunicorn lgtm |
gavofyork
added
A8-looksgood
and removed
A0-please_review
|
... although doesn't build? |
|
@gavofyork it's my lucky day, looks like pwasm-utils broke (on nightly), independently from this changeset :( . |
|
fix is here |
gnunicorn
force-pushed
the
ben-rename-hashing-trait
branch
from
fdbac97
to
5d83064
Compare
Adds trace_filter RPC endpoint, with a background task to keep a cache of the traces to avoid redundant computations.
* Change aura to babe consensus * . * cargo fmt * Add babe rpc * Nits * . * Change epoch duration to 5 minutes * .
Implement the creation of FraudProof
fixes #172 .
Rename
runtimes-primitives::traits::HashingtoHashto make it more idiomatic. Also replacesHashingForwithHashForand all the dependent uses of any of them in our code base. The cases I opted forHash as HashT-imports is because it would otherwise lead to conflicting/overwriting imports from other modules.Note: there is still one occurrence of
Hashingin the code base: as a type onHeader, which has bothHashandHashingtypes defined. I was thinking of renaming itHasherorHashedbut it wasn't clear to me what this is really referring to.