Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Upgrade trie-db crate to 0.16.0. #4144

Merged
merged 3 commits into from Nov 21, 2019
Merged

Upgrade trie-db crate to 0.16.0. #4144

merged 3 commits into from Nov 21, 2019

Conversation

jimpo
Copy link
Contributor

@jimpo jimpo commented Nov 19, 2019

The new version of trie-db has some breaking API changes, but the node encoding format remains the same.

@jimpo jimpo requested a review from cheme November 19, 2019 15:07
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good to me.
There is still probably a few minor change to do (cf CI).

Cargo.lock Outdated Show resolved Hide resolved
@cheme
Copy link
Contributor

cheme commented Nov 20, 2019

I guess trie-bench crate also need an update to new trie-db crate.

@jimpo jimpo merged commit 59b8b10 into paritytech:master Nov 21, 2019
@jimpo jimpo deleted the trie-update branch November 21, 2019 10:01
cheme added a commit to cheme/substrate that referenced this pull request Nov 25, 2019
@cheme cheme mentioned this pull request Nov 25, 2019
jimpo added a commit to jimpo/substrate that referenced this pull request Nov 26, 2019
cheme pushed a commit to cheme/substrate that referenced this pull request Nov 26, 2019
* Upgrade paritytech/trie crates to 0.16.0.

* Fix tests and unexpected Cargo.lock change.

* Bump trie-bench version.
cheme added a commit to cheme/substrate that referenced this pull request Nov 27, 2019
cheme pushed a commit to cheme/substrate that referenced this pull request Nov 27, 2019
* Upgrade paritytech/trie crates to 0.16.0.

* Fix tests and unexpected Cargo.lock change.

* Bump trie-bench version.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants