-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at first glance, I didn't analyse in details though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
A small concern that it seems that there is a chance to get a judgment without paying a fee, by racing cancelling the request before a judgment is processed.
pub IdentityOf get(fn identity): map T::AccountId => Option<Registration<BalanceOf<T>>>; | ||
|
||
/// Alternative "sub" identities of this account. | ||
pub SubsOf get(fn subs): map T::AccountId => (BalanceOf<T>, Vec<(T::AccountId, Data)>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be useful to say that the first tuple item is the deposit. I am also a bit unclear on how the second item would work, it has Data
but it doesn't describe what this data points to. To IdentityInfo
stored somewhere?
Well done! I was wondering if anyone would notice that. Yeah, if it turns out to be an issue (which I don't think it will since you'd pretty much need to be a validator to successfully beat the other tx in a race), then we can introduce an extra function |
Can't you add some tips to increase the priority of a transaction and therefore make it very likely the cancel tx get executed before the judgment tx? With a long-ish block time and short tx propagation time, the chance of success front-running can be pretty high. |
Closes #4311
A federated naming system, allowing for multiple registrars to be added from a specified origin. Registrars can set a fee to provide identity-verification service. Anyone can put forth a proposed identity for a fixed deposit and ask for review by any number of registrars (paying each of their fees). Registrar judgements are multi-tier allowing for more sophisticated opinions than a boolean true or false.
A super-user can remove accounts and slash the deposit.
The number of registrars should be limited, and the deposit made sufficiently large, to ensure no state-bloat attack is viable.
@jacogr incoming! :)
TODO: