Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove slog-async Github #4329

Merged
merged 4 commits into from Dec 9, 2019
Merged

Remove slog-async Github #4329

merged 4 commits into from Dec 9, 2019

Conversation

gnunicorn
Copy link
Contributor

By putting that record we are using directly into the crates–internal use only. Leaving a FIXME comment on the top to remove this once the PR has cleared.

Because this is completely internally an update removing this file and replacing the dependency later would only require a patch-level update.

@gnunicorn gnunicorn added the A0-please_review Pull request needs code review. label Dec 9, 2019
@gnunicorn gnunicorn added this to the 2.0 milestone Dec 9, 2019
@gnunicorn gnunicorn requested a review from tomaka December 9, 2019 11:56
@gnunicorn gnunicorn merged commit 8fe4b71 into master Dec 9, 2019
@gnunicorn gnunicorn deleted the ben-remove-slog-github branch December 9, 2019 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants