This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update Balances Pallet events to help block explorers #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
changed the title
gavofyork
reviewed
Dec 17, 2019
frame/balances/src/lib.rs
Outdated
| @@ -456,22 +458,35 @@ decl_module! { | |||
| ) { | |||
| ensure_root(origin)?; | |||
| let who = T::Lookup::lookup(who)?; | |||
| let existential_deposit = T::ExistentialDeposit::get(); | |||
| let mut final_free = new_free; | |||
There was a problem hiding this comment.
more cleanly written as let new_free = if new_free < existential_deposit { Zero::zero() } else { new_free }; since this doesn't leave an intermediate value around nor needs use of mut.
gavofyork
approved these changes
Dec 17, 2019
gavofyork
added
A6-mustntgrumble
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4382
The goal of this PR is to help an outside service like a block explorer to track the total token economy of the Balances Pallet through events, and without needing to querying individual account balances.
To accomplish this, we:
ReapedAccountevent to emit the dust burned when an account is reaped.BalanceSetevent to emit when root directly changes the balance of an account.This PR includes the following changes:
ReapedAccountevent now emits how much dust was burned.set_balancewith a value less than ED for either reserved or free, we automatically set the value to 0.set_balanceis called,BalanceSetevent is emitted with information about the user, final free balance, and final reserved balance.I am not sure this solves all the problems around tracking tokens within the system, but it should help.
Some example issues:
Follow up questions in the original issue.