babe: secondary blocks with VRF #5501

sorpaas · 2020-04-02T11:43:12Z

This enables secondary blocks (aura-block) with VRF in BABE. cc @burdges
Currently, secondary blocks in BABE only has slot number and authority index. This adds an additional secondary block type, which also contains an VRF. The VRF is not used in beacon randomness, but is available and may be useful for parachains.

It does not yet support live upgrade. This is due to BabeConfiguration currently only fetched from genesis block. Should be possible to lift the restriction in the future.

polkadot companion: paritytech/polkadot#1012

rphmeier · 2020-04-02T17:12:22Z

It does not yet support live upgrade. This is due to BabeConfiguration currently only fetched from genesis block. Should be possible to lift the restriction in the future.

Live upgrade from primary-only should not be possible but live upgrade from secondary to secondary-VRF should, right? This is the purpose of the check has_api_at(2) as I understand the code.

rphmeier · 2020-04-02T17:13:21Z

Also, @burdges should we be including these VRF outputs in the epoch randomness?

burdges · 2020-04-02T19:06:24Z

No. We'll only provide "fast" randomness to A&V and to parachains using this.

Primary blocks can freely choose their ancestors from among the recent secondary blocks, so including the secondary randomness would only increase the primary block producers influence of over the randomness beacon. Fewer choices is better. :)

sorpaas · 2020-04-02T21:37:47Z

Live upgrade from primary-only should not be possible but live upgrade from secondary to secondary-VRF should, right?

It does not yet in this PR. The consensus engine checks BabeConfiguration returned by runtime to determine if it should use a) primary only, b) primary and plain secondary, or c) primary and vrf secondary. So live upgrade from secondary to secondary-VRF still require live-reading of BabeConfiguration.

sorpaas · 2020-04-03T10:41:51Z

Attempted support for live upgrades of BABE engine #5514

… sp-aura-vrf

… sp-epoch-config

…ch types

… sp-aura-vrf

sorpaas · 2020-04-20T13:16:05Z

Would love if I can get some reviews on #5514 first, and then I can rebase this PR based on that.

…rate into sp-epoch-config

Co-Authored-By: André Silva <123550+andresilva@users.noreply.github.com>

…rate into sp-epoch-config

sorpaas · 2020-04-20T22:29:27Z

Rebased on #5514, so when merging, need to merge that first (merge #5514 first, and then merge this PR).

sorpaas · 2020-04-20T23:26:24Z

Tested syncing Kusama for the EpochChanges migration by syncing without this PR and then with the PR for a few hundred blocks, not detecting issues.

andresilva

lgtm, great work as usual :) could you update the polkadot companion PR? once it's green we can merge this and #5514.

… sp-aura-vrf

* Companion PR for paritytech#5501 * Bump runtime versions * add MaxRegistrars config * Pull substrate master in PR-5501 * Attempt to fix pin commit again * update to substrate master Co-authored-by: Alexander Popiak <alexander.popiak@parity.io> Co-authored-by: André Silva <andre.beat@gmail.com>

babe: secondary blocks with VRF

3517a80

sorpaas added the A0-please_review Pull request needs code review. label Apr 2, 2020

sorpaas requested review from andresilva and Demi-Marie as code owners April 2, 2020 11:43

Fix node runtime compile

ae38673

sorpaas added B2-breaksapi labels Apr 2, 2020

sorpaas added 2 commits April 2, 2020 13:56

Fix test-utils runtime interface

13aa495

Fix babe tests

c264025

sorpaas added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Apr 2, 2020

typo: v == 2

936253c

sorpaas added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 3, 2020

babe: support online configuration upgrades

5383f4d

sorpaas added 2 commits April 3, 2020 12:43

Fix rpc tests

2c91a14

Fix runtime version tests

06adbb9

sorpaas requested a review from tomusdrw as a code owner April 3, 2020 12:05

sorpaas added 2 commits April 3, 2020 16:38

Merge branch 'master' of https://github.com/paritytech/substrate into…

c1b502c

… sp-aura-vrf

Switch to use NextConfigDescriptor instead of changing runtime interface

8185b91

sorpaas mentioned this pull request Apr 7, 2020

babe: support online configuration upgrades #5514

Merged

sorpaas added 4 commits April 7, 2020 17:24

Merge branch 'master' of https://github.com/paritytech/substrate into…

e9c57dd

… sp-epoch-config

Fix tests

559b895

Merge branch 'master' into sp-epoch-config

9402233

epoch-changes: map function that allows converting with different epo…

682e3b7

…ch types

sorpaas added 2 commits April 20, 2020 15:13

Merge branch 'master' of https://github.com/paritytech/substrate into…

6a032b8

… sp-aura-vrf

Merge branch 'master' into sp-epoch-config

d978b67

sorpaas and others added 14 commits April 20, 2020 15:19

Add docs of SecondaryVRF in babe crate

d825d45

babe-primitives: Secondary -> SecondaryPlain

df540a4

babe-client: Secondary -> SecondaryPlain

42360ec

Fix migration tests

5144e80

Merge branch 'sp-epoch-config' of https://github.com/paritytech/subst…

bd102bc

…rate into sp-epoch-config

test-utils-runtime: Secondary -> SecondaryPlain

e049b81

Fix missing name change in test-utils-runtime

904df04

Fix migration: Epoch should be EpochV0

abba6a5

Update client/consensus/babe/src/lib.rs

ee72297

Co-Authored-By: André Silva <123550+andresilva@users.noreply.github.com>

Fix new epochChanges version

52bc6f9

Merge branch 'sp-epoch-config' of https://github.com/paritytech/subst…

60f4f80

…rate into sp-epoch-config

Merge branch 'sp-epoch-config' into sp-aura-vrf

4e9490d

Fix babe-primitives naming changes

3b889a3

Fix merge issues in babe-client

6cf220a

sorpaas mentioned this pull request Apr 20, 2020

Companion PR for #5501 and #5680 paritytech/polkadot#1012

Merged

sorpaas mentioned this pull request Apr 22, 2020

Update Babe Specification in Consensus Chapter w3f/polkadot-spec#46

Closed

4 tasks

andresilva approved these changes Apr 22, 2020

View reviewed changes

sorpaas and others added 3 commits April 23, 2020 17:39

Merge branch 'master' of https://github.com/paritytech/substrate into…

2d1295e

… sp-aura-vrf

Merge branch 'master' into sp-aura-vrf

4c12ea8

Merge branch 'master' into sp-aura-vrf

b2e9eba

andresilva mentioned this pull request Apr 24, 2020

babe: remove error fallback from threshold calculation #5764

Merged

andresilva merged commit cddb42c into master Apr 24, 2020

andresilva deleted the sp-aura-vrf branch April 24, 2020 15:03

sorpaas mentioned this pull request Oct 24, 2022

Membership request polkadot-fellows/seeding#50

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

babe: secondary blocks with VRF #5501

babe: secondary blocks with VRF #5501

sorpaas commented Apr 2, 2020 •

edited by andresilva

rphmeier commented Apr 2, 2020

rphmeier commented Apr 2, 2020

burdges commented Apr 2, 2020

sorpaas commented Apr 2, 2020

sorpaas commented Apr 3, 2020

sorpaas commented Apr 20, 2020

sorpaas commented Apr 20, 2020 •

edited

sorpaas commented Apr 20, 2020

andresilva left a comment

babe: secondary blocks with VRF #5501

babe: secondary blocks with VRF #5501

Conversation

sorpaas commented Apr 2, 2020 • edited by andresilva

rphmeier commented Apr 2, 2020

rphmeier commented Apr 2, 2020

burdges commented Apr 2, 2020

sorpaas commented Apr 2, 2020

sorpaas commented Apr 3, 2020

sorpaas commented Apr 20, 2020

sorpaas commented Apr 20, 2020 • edited

sorpaas commented Apr 20, 2020

andresilva left a comment

Choose a reason for hiding this comment

sorpaas commented Apr 2, 2020 •

edited by andresilva

sorpaas commented Apr 20, 2020 •

edited