Add rejected blocks metric #6006
Conversation
|
It looks like @CodeSandwich signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
| @@ -175,6 +181,7 @@ impl< | |||
| "Stopping after #{} blocks because of an error", | |||
| link.imported_blocks, | |||
| ); | |||
| rejected_blocks_number.fetch_add(1, Ordering::Relaxed); | |||
There was a problem hiding this comment.
I think you've confused the location here. This is the import-cli command. In this context we a) don't have metrics activated, nor are we sending them anywhere and b) fail immediately on the error, thus the number would always be 1 and never actually increase.
There was a problem hiding this comment.
This isn't how we usually design the metrics. Rather than having them all on service, we track them as close to the source as possible and ideally already use prometheus measuring structs directly (they are more optimised).
For this case, that would mean we want to measure in primitives/consensus/common/src/import_queue/basic_queue with a generic u64 counter and register it from the service-metrics.
|
closed in favor of #6025 . |
Adds a metric for blocks rejected from the import queue as invalid. Fixes #6005.