This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
client/network: Allow configuring Kademlia's disjoint query paths #7356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rust libp2p-kad implementation can require iterative queries to use disjoint paths for increased resiliency in the presence of potentially adversarial nodes. Allow Substrate users to enable this feature via the `--kademlia-disjoint-query-paths` flag.
mxinden
added
A0-please_review
mxinden
commented
Oct 19, 2020
| @@ -144,48 +141,71 @@ impl DiscoveryConfig { | |||
|
|
|||
| /// Add discovery via Kademlia for the given protocol. | |||
| pub fn add_protocol(&mut self, id: ProtocolId) -> &mut Self { | |||
| let name = protocol_name_from_protocol_id(&id); | |||
| self.add_kademlia(id, name); | |||
There was a problem hiding this comment.
Creation of Kademlia instances is moved into fn finish. Otherwise users could first call add_protocol and then use_kademlia_disjoint_query_paths with the latter not taking any effect given that the Kademlias are already created.
romanb
approved these changes
Oct 19, 2020
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust libp2p-kad implementation can require iterative queries to use
disjoint paths for increased resiliency in the presence of potentially
adversarial nodes.
Allow Substrate users to enable this feature via the
--kademlia-disjoint-query-pathsflag.Release note suggestion: