Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Telemetry refactor #757

Merged
merged 3 commits into from
Sep 17, 2018
Merged

Telemetry refactor #757

merged 3 commits into from
Sep 17, 2018

Conversation

maciejhirsz
Copy link
Contributor

  • Replaced the websocket crate with ws.
  • TelemetryWriter starts a child thread which spins the ws connection event loop. This thread answers all ping frames with pong frames as well as handles reconnects. In catastrophic scenario where the whole event loop comes crashing down, it will just spin a new one.
  • The reconnect every 2 minutes is removed. We can add something analog back if necessary (timing out on ping?) but from what I've tested if I disable and re-enable wifi the connection resets properly.
  • Added few more traces.

@maciejhirsz maciejhirsz added the A0-please_review Pull request needs code review. label Sep 17, 2018
@gavofyork gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Sep 17, 2018
@gavofyork gavofyork merged commit 690a29e into master Sep 17, 2018
@gavofyork gavofyork deleted the mh-telemetry-refactor branch September 17, 2018 16:43
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
* Bump Substrate

* Bump RT version

* Bump substrate, add new modules

* Fix

* Bump Substrate

* Bump impl version

* Address grumbles
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* fix all tests

* let AccountId is Public

* fix bug for lock tx with unlock input

* fix some features

1. fix 50 for reward relayer
2. let handle return Err when not match limit

* test and event

1. normal test pass
2. move binding event
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
Bumps [JasonEtco/create-an-issue](https://github.com/JasonEtco/create-an-issue) from 2.8.2 to 2.9.1.
- [Release notes](https://github.com/JasonEtco/create-an-issue/releases)
- [Commits](JasonEtco/create-an-issue@3a8ba79...e27dddc)

---
updated-dependencies:
- dependency-name: JasonEtco/create-an-issue
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants