Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use the precise number of approvals when constructing RawOrgin::Members #9647

Merged
13 commits merged into from
Sep 13, 2021
Merged

Use the precise number of approvals when constructing RawOrgin::Members #9647

13 commits merged into from
Sep 13, 2021

Conversation

liuchengxu
Copy link
Contributor

Close #9604

@liuchengxu
Copy link
Contributor Author

Can you please take a look at this PR? @shawntabrizi @thiolliere

@shawntabrizi
Copy link
Member

Okay, this makes sense to me. Can you please write a test?

@shawntabrizi shawntabrizi added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Sep 10, 2021
@shawntabrizi shawntabrizi added this to In progress in Runtime via automation Sep 10, 2021
@liuchengxu
Copy link
Contributor Author

@shawntabrizi Added a test in liuchengxu@118c272. I also separated out tests.rs and did some refactoring, but should be easy to review by each commit.

@thiolliere
Copy link
Contributor

maybe you need to merge master to fix CI

thiolliere
thiolliere reviewed Sep 10, 2021
View reviewed changes
Copy link
Contributor

@thiolliere thiolliere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me too.

thiolliere
thiolliere approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@thiolliere thiolliere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me,

@liuchengxu
Copy link
Contributor Author

and we should revert this change https://github.com/paritytech/substrate/pull/9647/files#r706082154

@thiolliere Not sure I fully understand this, do you mean we should use the hardcoded proposal hash instead of using the variable hash?

@thiolliere
Copy link
Contributor

thiolliere commented Sep 11, 2021 •
edited
Loading

and we should revert this change https://github.com/paritytech/substrate/pull/9647/files#r706082154

@thiolliere Not sure I fully understand this, do you mean we should use the hardcoded proposal hash instead of using the variable hash?

it was about the commit to try to fix CI. But master has been merged with the fix. so all good to me now.

Runtime automation moved this from In progress to Needs Audit Sep 12, 2021
@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Sep 13, 2021

Trying merge.

@ghost ghost merged commit 5810c46 into paritytech:master Sep 13, 2021
Runtime automation moved this from Needs Audit to Done Sep 13, 2021
@liuchengxu liuchengxu deleted the use-yes_votes-instead-of-voting.threshold branch September 13, 2021 03:39
@shawntabrizi shawntabrizi moved this from Done to Archive in Runtime Sep 30, 2021
@github-actions github-actions bot mentioned this pull request Oct 11, 2021
Closed
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@thiolliere thiolliere thiolliere approved these changes

Assignees
No one assigned
Labels
C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use yes_votes instead of voting.threshold when constructing RawOrigin::Members in pallet-collective
3 participants
@liuchengxu @shawntabrizi @thiolliere