Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Timestamp inherent doesn't pay fees #9791

Closed
wants to merge 5 commits into from
Closed

Timestamp inherent doesn't pay fees #9791

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98690a6
timestamp inherent shouldn'tpay fees.
JoshOrndorff Sep 15, 2021
984f560
Revert "timestamp inherent shouldn'tpay fees."
JoshOrndorff Sep 15, 2021
6e2a39d
Do it pre-dispatch
JoshOrndorff Sep 15, 2021
b8d77fa
Revert "Do it pre-dispatch"
JoshOrndorff Sep 16, 2021
910912b
Revert "Revert "timestamp inherent shouldn'tpay fees.""
JoshOrndorff Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frame/timestamp/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ pub mod pallet {
/// # </weight>
#[pallet::weight((
T::WeightInfo::set(),
DispatchClass::Mandatory
DispatchClass::Mandatory,
Pays::No,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sending a signed extrinsic with the call set free, which is not good, even if it will fails directly it can still fill some block for free

))]
pub fn set(origin: OriginFor<T>, #[pallet::compact] now: T::Moment) -> DispatchResult {
ensure_none(origin)?;
Expand Down