Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add extrinsic to improve position in a bag of bags-list #9829

Merged
merged 42 commits into from
Dec 8, 2021
Merged

Add extrinsic to improve position in a bag of bags-list #9829

merged 42 commits into from
Dec 8, 2021

Commits on Sep 21, 2021

  1. pallet-bags-list: Add put_in_front_of extrinsic 

    This PR adds the extrinsic `put_in_front_of` which allows the user to specify a `lighter` and `heavier` account within the same bag. The extrinsic will move `heavier` directly in front of `lighter`.  The parameter names refer to the fact that `lighter` must have a lower `VoteWeight` then `heavier`. 

In the ideal use case, where a user wants to improve the position of their account within a bag, the user would iterate the bag, starting from the head, and find the first node who's `VoteWeight` is less than theirs. They would then supply the `id` of the node as the `lighter` argument and their own `id` as the `heavier` argument.
    @emostov
    emostov committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    c414583 View commit details
    Browse the repository at this point in the history

  2. Test & Benchmarks

    @emostov
    emostov committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    331df1b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin' into zeke-change-bag-position

    @emostov
    emostov committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    e7c016c View commit details
    Browse the repository at this point in the history

  4. Respect line width

    @emostov
    emostov committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    2401b2b View commit details
    Browse the repository at this point in the history

  5. Remove List::put_in_fron_of tests; Remove AlreadyHigher error

    @emostov
    emostov committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    60743cc View commit details
    Browse the repository at this point in the history

  6. The dispatch origin for this call must be ...

    @emostov
    emostov committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    6bb232f View commit details
    Browse the repository at this point in the history

  7. Add some periods

    @emostov
    emostov committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    45f4a73 View commit details
    Browse the repository at this point in the history

  8. Add back test to list module: put_in_front_of_exits_early_if_bag_not_… 

    …found
    @emostov
    emostov committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    f04a64c View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin' into zeke-change-bag-position

    @emostov
    emostov committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    ce0fcfb View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. add test tests::pallet::heavier_is_head_lighter_is_not_terminal

    @emostov
    emostov committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    aa0aaeb View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Cater for edge case of heavier being head

    @emostov
    emostov committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    fa1a33d View commit details
    Browse the repository at this point in the history

  2. Add ExtBuilder::add_aux_data; try to make some tests use simpler data

    @emostov
    emostov committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    21aef98 View commit details
    Browse the repository at this point in the history

  3. Update frame/bags-list/src/list/tests.rs

    @emostov
    emostov committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    7433cf6 View commit details
    Browse the repository at this point in the history

  4. make insert_at_unchecked infallible

    @emostov
    emostov committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    1760815 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'zeke-change-bag-position' of https://github.com/parityt… 

    …ech/substrate into zeke-change-bag-position
    @emostov
    emostov committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    fcc29d2 View commit details
    Browse the repository at this point in the history

  6. Make it permissioned - only callable by heavier

    @emostov
    emostov committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    afff2a9 View commit details
    Browse the repository at this point in the history

  7. Add test cases for insert_at_unchecked

    @emostov
    emostov committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    b75457f View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2021

  1. Move counter update to insert_at; fix comments

    @emostov
    emostov committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    fd1daeb View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2021

  1. Try merge origin master

    @emostov
    emostov committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    f5a854f View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. Merge remote-tracking branch 'origin' into zeke-change-bag-position

    @emostov
    emostov committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    a12f094 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Merge remote-tracking branch 'origin' into zeke-change-bag-position

    @emostov
    emostov committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    d5f82ac View commit details
    Browse the repository at this point in the history

  2. Address some feedback

    @emostov
    emostov committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    f3f992c View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Make voteweight constructed with parameter_types

    @emostov
    emostov committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    927a383 View commit details
    Browse the repository at this point in the history

  2. Always set vote weight for Ids in build

    @emostov
    emostov committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    387ab0d View commit details
    Browse the repository at this point in the history

  3. Add skip_genesis_ids

    @emostov
    emostov committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    7d5a1ca View commit details
    Browse the repository at this point in the history

  4. Do not pass weight fn to List put_in_front_of

    @emostov
    emostov committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    2add927 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Merge remote-tracking branch 'origin' into zeke-change-bag-position

    @emostov
    emostov committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    fe120d6 View commit details
    Browse the repository at this point in the history

  2. Remove remants of CounterForListNodes

    @emostov
    emostov committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    d135b8f View commit details
    Browse the repository at this point in the history

  3. fmt

    @emostov
    emostov committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    7530d1a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/paritytech/substrate into… 

    … zeke-change-bag-position
    Parity Bot committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    cd39dc9 View commit details
    Browse the repository at this point in the history

  5. cargo run --quiet --release --features=runtime-benchmarks --manifest-… 

    …path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
    Parity Bot committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    fd751fc View commit details
    Browse the repository at this point in the history

  6. Delete messed up weights file

    @emostov
    emostov committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    f5b0224 View commit details
    Browse the repository at this point in the history

  7. Some place holder stuff so we can run bench in CI

    @emostov
    emostov committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    91317bd View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Fix

    @emostov
    emostov committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    6af64ce View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/paritytech/substrate into… 

    … zeke-change-bag-position
    Parity Bot committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    3382286 View commit details
    Browse the repository at this point in the history

  3. cargo run --quiet --release --features=runtime-benchmarks --manifest-… 

    …path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
    Parity Bot committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    56ea8cc View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Merge remote-tracking branch 'origin' into zeke-change-bag-position

    @emostov
    emostov committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    a96e495 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Update frame/bags-list/src/list/mod.rs 

    Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
    @emostov @thiolliere
    emostov and thiolliere committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    77fd777 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. fmt

    @emostov
    emostov committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    aa4d896 View commit details
    Browse the repository at this point in the history

  2. Log + debug assert when refetching an Id

    @emostov
    emostov committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    944dc85 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin' into zeke-change-bag-position

    @emostov
    emostov committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    ae188ae View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin' into zeke-change-bag-position

    @emostov
    emostov committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    2eb86e5 View commit details
    Browse the repository at this point in the history