Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tokio instead of async-std. #485

Closed
jsdw opened this issue Mar 21, 2022 · 0 comments · Fixed by #495
Closed

Use tokio instead of async-std. #485

jsdw opened this issue Mar 21, 2022 · 0 comments · Fixed by #495

Comments

@jsdw
Copy link
Collaborator

jsdw commented Mar 21, 2022

Jsonrpsee (a dependency) uses tokio under the hood. Would it make sense for subxt to align on this and also use tokio instead of async-std (which is currently only a dev dependency anyway) to avoid pulling in both?

From a quick glacne it looks like it would be a fairly trivial swap; #[async_std::test] tp #[tokio::test] and a few other similarly easy changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant