Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tokio instead of async-std #495

Merged
merged 4 commits into from
Apr 1, 2022
Merged

Use tokio instead of async-std #495

merged 4 commits into from
Apr 1, 2022

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Apr 1, 2022

Remove the async-std dependency and utilize tokio instead.
This is motivated by the fact that jsonrpsee utilizes under the hood tokio.

Closes #485.

@lexnv
examples: Use tokio instead of std async
3986be1 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
test-runtime: Use tokio instead of std async
f84099d 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
subxt: Use tokio instead of std async
40cf35f 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
examples: Use only necessary tokio features
b13b005 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
niklasad1
niklasad1 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice with a smaller dependency tree, LGTM

ascjones
ascjones approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

jsdw
jsdw approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff!

@lexnv lexnv merged commit 6ce9983 into master Apr 1, 2022
@lexnv lexnv deleted the 485_use_tokio_async branch April 1, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use tokio instead of async-std.
4 participants
@lexnv @ascjones @jsdw @niklasad1