Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors the api #113

Merged
merged 4 commits into from
May 26, 2020
Merged

Refactors the api #113

merged 4 commits into from
May 26, 2020

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented May 25, 2020

Makes things much cleaner and easier. Moves the signing logic out into a signer. Should make it easier to support hardware wallets down the road, although the api probably needs to change to return a Future<Output=Result<Signed, Error>>.

Closes #108

Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer API. Just a few nits

src/signer.rs Outdated Show resolved Hide resolved
src/signer.rs Outdated Show resolved Hide resolved
.github/workflows/rust.yml Show resolved Hide resolved
src/signer.rs Outdated Show resolved Hide resolved
src/signer.rs Outdated Show resolved Hide resolved
src/extrinsic.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones merged commit 67f3ce5 into paritytech:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transaction signer
2 participants