CLI Tool: Allow using --file - to read metadata from stdin
#1336
Conversation
| impl FromStr for PathOrStdIn { | ||
| type Err = <PathBuf as FromStr>::Err; | ||
|
|
||
| fn from_str(s: &str) -> Result<Self, Self::Err> { |
There was a problem hiding this comment.
I wonder whether we should trim the leading and trailing whitespaces before checking that the --file -
There was a problem hiding this comment.
and a simple test for the from_str impl would be nice to have.
There was a problem hiding this comment.
I think regarding trimming, clap already takes care of that before the args are given to us to parse, but I am not entirely sure.
There was a problem hiding this comment.
worth a quick check but I'd assume the shell would handle it :)
(and if the user provides something like ' - ' as an argument then I wouldn't expect that to be treated as stdin anyways. Edit: Ah I can see it's trimmed now; that's fine too; either way works!)
There was a problem hiding this comment.
Tadeo added trimming and tests for it :)
fixes #1326
I tested it manually by running
subxt metadata | subxt codegen --file -(which is not super useful obviously) but shows that it works for the requested usecase of runningparachain-node export-metadata | subxt codegen --file -.