[audit] Update DispatchError to match latest in polkadot-sdk #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
reviewed
Feb 23, 2024
| @@ -59,6 +59,9 @@ pub enum DispatchError { | |||
| "Some resource (e.g. a preimage) is unavailable right now. This might fix itself later." | |||
| )] | |||
| Unavailable, | |||
| /// Root origin is not allowed. | |||
| #[error("Root origin is not allowed.")] | |||
| RootNotAllowed, | |||
There was a problem hiding this comment.
Would be interesting if we could automatically check that all types we have from substrate are in sync.
I'm not aware of a clean way to do that.
We could probably explore in the future a custom crate that compares the tokens from this type to a github link, or crate version.
#[sync_test(
git = "https://github.com/paritytech/polkadot-sdk/blob/master/substrate",
path = "substrate/primitives/runtime/src/lib.rs"
)
enum SubstrateType {
...
}There was a problem hiding this comment.
That's an interesting idea!
lexnv
approved these changes
Feb 23, 2024
niklasad1
approved these changes
Feb 23, 2024
niklasad1
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auditors spotted that our DispatchError type had fallen a bit out of sync with the latest one found here https://github.com/paritytech/polkadot-sdk/blob/master/substrate/primitives/runtime/src/lib.rs#L564-L598.