Swap BinaryHeap for Vec to avoid Ord constraint issue #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
approved these changes
Apr 10, 2024
niklasad1
changed the title
jsdw
changed the title
niklasad1
pushed a commit
that referenced
this pull request
Apr 11, 2024
* Swap BianryHeap for KeyedVec to avoid Ord constraint issue * Vec, not KeyedVec
niklasad1
pushed a commit
that referenced
this pull request
Apr 11, 2024
* Swap BianryHeap for KeyedVec to avoid Ord constraint issue * Vec, not KeyedVec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitute BinaryHeap for Vec in the same way that we do for BTreeMap/Set to avoid issues with the
Ordconstraint on the generic type (because this may be a generated type, and we don't automatically applyOrdto generated types).Now that we have recursive derives, we might be able to be smarter about this sort of thing in the future by autoamtically recursively deriving Ord on the relevant types (which should be OK because it would very likely have existed on the ndoe side anyway to be using such types)
Closes #1515