Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize transactionWatch methods #1539

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Stabilize transactionWatch methods #1539

merged 4 commits into from
Apr 20, 2024

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Apr 19, 2024

This PR stabilizes the transactionWatch methods in response to:

cc @paritytech/subxt-team

@lexnv
Stabilize transactionWatch
1816416 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv self-assigned this Apr 19, 2024
@lexnv lexnv requested a review from a team as a code owner April 19, 2024 08:44
@lexnv lexnv changed the title Stabilize transactionWatch Stabilize transactionWatch methods Apr 19, 2024
lexnv and others added 2 commits April 19, 2024 11:51
@lexnv
Keep consistency in naming method class
fe0d222 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@niklasad1
Merge branch 'master' into lexnv/stable-txWatch
ccaa43f
niklasad1
niklasad1 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we should rename it fn transaction_watch_v1_xx(..) instead of fn transactionwatch_v1_xx but all good

@niklasad1 niklasad1 merged commit 33a891b into master Apr 20, 2024
12 checks passed
@niklasad1 niklasad1 deleted the lexnv/stable-txWatch branch April 20, 2024 12:31
@niklasad1 niklasad1 mentioned this pull request Apr 20, 2024
Closed
@jsdw jsdw mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees

@lexnv lexnv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lexnv @niklasad1