Update deps to use scale-type-resolver 0.2
#1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
commented
Apr 29, 2024
| // TODO: When `scale-type-resolver` [provides struct names](https://github.com/paritytech/scale-type-resolver/issues/4), check that this struct name is `WrapperKeepOpaque` | ||
| use scale_decode::visitor::DecodeError; | ||
|
|
||
| if value.name() != Some("WrapperKeepOpaque") { |
There was a problem hiding this comment.
We can get the struct name now for a little additional sanity check that our custom logic here makes sense given the target type.
lexnv
approved these changes
Apr 29, 2024
niklasad1
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly this just means converting
&type_ids totype_ids as we pass them by value and not reference now.Also add back a check in
WrapperKeepOpaqueto confirm that the struct we're pointing at is the right one, to resovle a small TODO.