[jsonrpsee http client]: support tokio1 & tokio02. #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
reviewed
Apr 12, 2021
Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| log = "0.4.14" | ||
| thiserror = "1.0.24" | ||
| futures = "0.3.13" | ||
| jsonrpsee-types = "=0.2.0-alpha.3" | ||
| jsonrpsee-ws-client = "=0.2.0-alpha.3" | ||
| jsonrpsee-http-client = "=0.2.0-alpha.3" | ||
| jsonrpsee-http-client = { version = "=0.2.0-alpha.3", default-features = false, optional = true } |
There was a problem hiding this comment.
Why is it optional, in case we use default-features = false when depending on subxt. Wouldn't that cause a compilation error?
There was a problem hiding this comment.
right good catch, it doesn't need to be optional.
However, if tokio1 or tokio02 is not enabled on jsonrpsee-http-client it will be a compilation error anyway. So doesn't really make a difference in practice.
Thus, if users don't use the default features and not enabled exactly one the features the compilation error might be a little tricky to figure out.
We got this https://github.com/paritytech/jsonrpsee/blob/master/http-client/src/lib.rs#L23-#L27 for now hopefully this goes away very soon but probably not ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262
As
substrateand some of the Rust ecosystem hasn't updated totokio 1yet, let's make it configurable to support eithertokio0.2ortokio 1.//cc @akru can you try this to ensure that it actually fixes your issue ^^