Additional parameters for SignedExtra #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be an up-to-date version of #204 |
jsdw
reviewed
Nov 15, 2021
src/extrinsic/extra.rs
Outdated
| @@ -230,13 +230,16 @@ impl SignedExtension for ChargeTransactionPayment { | |||
| pub trait SignedExtra<T: Config>: SignedExtension { | |||
| /// The type the extras. | |||
| type Extra: SignedExtension + Send + Sync; | |||
| /// The extra config parameters. | |||
| type Config: Default + Send + Sync; | |||
There was a problem hiding this comment.
Nit: I was initially a bit confused as there is also a Config trait above. Perhaps this should be called something more unique (and vague) like Other, since presumably its goal is simply to allow other arbitrary data to be provided?
There was a problem hiding this comment.
Parameters sounds better. Renamed.
kvinwang
force-pushed
the
confi-extra
branch
from
8cb31c3
to
8169327
Compare
kvinwang
changed the title
insipx
approved these changes
Nov 16, 2021
jsdw
approved these changes
Nov 17, 2021
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to control the transaction longevity in our application. subxt does's have an API to do so.
We can use a custom SignedExtra implementation to fill the CheckMortality parameters. However, a custom SignedExtra has no way to be passed in extra infomation to construct the CheckMortality. This PR add an associated type to allow SignedExtra to carry some custom data to construct the signed extra. Check here for more detail.