Expand the subscribe_and_watch example
#361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
reviewed
Dec 10, 2021
niklasad1
reviewed
Dec 10, 2021
niklasad1
reviewed
Dec 10, 2021
| } | ||
| } | ||
| // Finalized! | ||
| else if let Finalized(details) = ev { |
There was a problem hiding this comment.
wasn't aware of this syntax but I prefer matching regardless :)
There was a problem hiding this comment.
Aah, I kept flicking between a match and if let here, but since I only wanted to check for two states I thoughtI'd save a level of indentation with if let :)
niklasad1
reviewed
Dec 10, 2021
| @@ -436,7 +436,7 @@ impl<T: Config> TransactionEvents<T> { | |||
| } | |||
|
|
|||
| /// Find an event. Returns true if it was found. | |||
| pub fn has_event<E: crate::Event>(self) -> Result<bool, Error> { | |||
| pub fn has_event<E: crate::Event>(&self) -> Result<bool, Error> { | |||
niklasad1
approved these changes
Dec 10, 2021
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
dvdplm
approved these changes
Dec 10, 2021
| let events = balance_transfer.fetch_events().await?; | ||
|
|
||
| let failed_event = | ||
| events.find_first_event::<polkadot::system::events::ExtrinsicFailed>()?; |
There was a problem hiding this comment.
Worth mentioning how find_first_event could return error?
There was a problem hiding this comment.
I don't think it's worth an explicit shout out in the example really, but I added this note to the docs for the relevant methods because it wasn't clear enough there :)
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
* Expand the subscribe_and_watch example * Fix comment typos Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> Co-authored-by: Zeke Mostov <z.mostov@gmail.com> * Add note about error on decoding events Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make
has_eventtake&self; it does not need or want ownership.