fetch system chain, name and version #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
reviewed
Jan 6, 2022
There was a problem hiding this comment.
Nice, please add some tests for these though.
Just something like
subxt/tests/integration/client.rs
Line 51 in 415e122
paulormart
force-pushed
the
pm-rpc-fetch-system
branch
from
aa2b447
to
fc916e2
Compare
ascjones
reviewed
Jan 6, 2022
jsdw
approved these changes
Jan 10, 2022
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
* fetch system chain, name and version * add fetch system tests * fix fetch system test * fix cargo fmt * fix cargo clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this additional information useful to be available from a client tool perspective. And goes in line with the methods available in
polkadot.js.