Expose the SCALE encoded call data of an extrinsic #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
approved these changes
Jun 20, 2022
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
ascjones
approved these changes
Jun 22, 2022
| pub fn call_data(&self) -> Result<Vec<u8>, BasicError> { | ||
| let mut bytes = Vec::new(); | ||
| let locked_metadata = self.client.metadata(); | ||
| let metadata = locked_metadata.read(); |
There was a problem hiding this comment.
This pattern is very common to use the read only locked metadata, I wonder whether it is worth adding a method for that.
There was a problem hiding this comment.
Mmm yeah, quite possibly; it might also be worth just cloning it out of the lock immediately too since it's behind an Arc iirc; no need to actually hold the lock for any appreciable amount of time either I think!
There was a problem hiding this comment.
Cloning the metadata seems a bit wasteful in most cases since as you say it is usually short lived
Sorry I misunderstood what you meant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #571