Use scale-decode to help optimise event decoding #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
changed the title
jsdw
force-pushed
the
jsdw-use-scale-decode
branch
from
c050c9a
to
319b7b1
Compare
lexnv
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip over event bytes using the
IgnoreVisitorfromscale_decode, and only decode fields intoValues if we ask for them explicitly.Also avoid cloning event bytes around the place by reusing the same Vec (
Arc<[u8]>) everywhere and avoiding any string cloning (again, pushing the work until the user asks for pallet/variant name), and tidy the API around working with events a little.This builds off the big API change of #593.