Make it possible to get raw bytes back from dynamic constant/storage queries #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
changed the title
jsdw
changed the title
|
@niklasad1 perhaps this helps avoid a case of having to SCALE encode the storage thing to bytes in staking-miner; it makes sense to me that you can just retrieve the bytes directly anyway for these calls (you already can get the bytes for events and transactions at each stage afterall). |
niklasad1
approved these changes
Oct 3, 2022
|
Ah whoops; I didn't notice those! I'll reset and get rid of them! |
jsdw
force-pushed
the
jsdw-dynamic-value-thunk
branch
from
c87b4a5
to
5df693c
Compare
ascjones
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you make a dynamic storage or constant query at the moment, you get back a
Value. In some cases, you might just want the raw SCALE bytes back to do as you wish with (eg here: https://github.com/paritytech/staking-miner-v2/pull/387/files#diff-6e448cdd99756118d32afe57b3d7d260cb1626cdbdbace46a91f1f9d20aabd4eR118.).This PR makes dynamic things decode into this intermediate
DecodedValueThunktype, from which you can either finish decoding into a value with.to_value()or access the bytes with.to_encoded()to do as you wish with instead.