Extend the new api.blocks() to be the primary way to subscribe and fetch blocks/extrinsics/events
#691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
reviewed
Oct 18, 2022
lexnv
reviewed
Oct 18, 2022
jsdw
changed the title
api.blocks() to be the primary way to subscribe and fetch blocks/extrinsics/events
lexnv
approved these changes
Oct 24, 2022
mep-jerry
reviewed
Oct 26, 2022
Co-authored-by: Andrew Jones <ascjones@gmail.com>
|
New |
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Extrinsictype from config (We just treat every extrinsic as a collection of bytes at the moment, and if/when we want to decode them properly we can treat them like events and ask for a type/shape at decode time).api.blocks().subscribe_*()the only way to subscribe to streams of things (removing similar functionality from Events to avoid lots of repetition and simplify the API surface).FilterEventsstuff; it makes much more sense to ask for events via this new blocks API (either for the entire block or for specific extrinsics), and it was all rather complicated.