Add Cargo.lock for deterministic builds
#795
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
| 5. Ensure the `Cargo.lock` file is up to date. | ||
|
|
||
| ``` | ||
| cargo generate-lockfile |
There was a problem hiding this comment.
This command will create the Cargo.lock lockfile for the current package or workspace. If the lockfile already exists, it will be rebuilt with the latest available version of every package.
should we really bump all dependencies to the latest on each release?
I guess our tests are sufficient but I'm a little bit scared bumping all.
There was a problem hiding this comment.
bump to latest compatible with substrate.
There was a problem hiding this comment.
should we really bump all dependencies to the latest on each release?
I guess our tests are sufficient but I'm a little bit scared bumping all.
Ah I didn't realise that also bumped dependencies. I guess I'm not too worried overall since it'll just be thel ate3st that our toml files are asking for anyway, which is what a fresh install of everything would bring in?
bump to latest compatible with substrate.
Pardon? The substrate deps won't be bumepd by this thing
This PR adds a
Cargo.lockfile to the repository to ensure we have a deterministic build.While at it, add an extra step in our releasing process to ensure we are always releasing with an up-to-date lock file.
The lock file has been generated with
cagro clean && cargo build --releaseand double checked withcargo generate-lockfile