Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use blake2 for extrinsic hashing #921

Merged
merged 1 commit into from Apr 24, 2023
Merged

use blake2 for extrinsic hashing #921

merged 1 commit into from Apr 24, 2023

Conversation

seunlanlege
Copy link
Contributor

@seunlanlege seunlanlege commented Apr 22, 2023 •
edited

Substrate uses blake2_256 for extrinsic hashing regardless of the configured hasher for the runtime

https://github.com/paritytech/substrate/blob/c7d26dcf3d6c19fa7dcbd1f2633e337e5a5cbc40/primitives/runtime/src/generic/unchecked_extrinsic.rs#L211-L228

@seunlanlege seunlanlege requested a review from a team as a code owner April 22, 2023 10:17
jsdw
jsdw approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@jsdw jsdw merged commit 92f5417 into paritytech:master Apr 24, 2023
7 checks passed
@jsdw jsdw mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@jsdw jsdw jsdw approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seunlanlege @ascjones @jsdw @lexnv