Cli tool tests #977
Merged
Cli tool tests #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadeohepperle
force-pushed
the
tadeo-hepperle-cli-tool-tests
branch
from
8dc3421
to
df00dd5
Compare
jsdw
reviewed
Jun 13, 2023
cli/src/utils.rs
Outdated
Comment on lines
98
to
106
| /// Given a type definition, return type ID and registry representing it. | ||
| #[allow(dead_code)] | ||
| pub fn make_type<T: scale_info::TypeInfo + 'static>() -> (u32, scale_info::PortableRegistry) { | ||
| let m = scale_info::MetaType::new::<T>(); | ||
| let mut types = scale_info::Registry::new(); | ||
| let id = types.register_type(&m); | ||
| let portable_registry: scale_info::PortableRegistry = types.into(); | ||
| (id.id, portable_registry) | ||
| } |
There was a problem hiding this comment.
move this to the test mod, or mark as #[cfg(test)] if it's used by other tests, to avoid the #[allow(dead_code)] (and make clear it's only used in testing)
jsdw
approved these changes
Jun 13, 2023
niklasad1
reviewed
Jun 14, 2023
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_commands() { |
There was a problem hiding this comment.
I would prefer to split this test into smaller ones because it's much harder to debug if something breaks.
There was a problem hiding this comment.
Sure, I will split it up in another PR today.
niklasad1
reviewed
Jun 14, 2023
| let (foo_type_id, foo_registry) = make_type::<Foo>(); | ||
| let description = print_type_description(&foo_type_id, &foo_registry).unwrap(); | ||
| let mut output = String::new(); | ||
| writeln!(output, "struct Foo {{").unwrap(); |
There was a problem hiding this comment.
may this works as well:
let s = r#"struct Foo {
hello: String,
num: i32
}"#;
niklasad1
approved these changes
Jun 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partly fixes #946
I added a Writer (
&mut impl std::io::Write) to each cli command such that we can write to it instead ofstdout.This makes it easy to test the expected output of each command.
Added tests for some commands.