Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depending on @substrate/txwrapper-dev #314

Closed
EmilIvanichkovv opened this issue Jul 5, 2023 · 3 comments
Closed

Depending on @substrate/txwrapper-dev #314

EmilIvanichkovv opened this issue Jul 5, 2023 · 3 comments

Comments

@EmilIvanichkovv
Copy link
Contributor

Greetings! 👋

We are currently working on an open-source library that aims to facilitate offline decoding of Polkadot and Westend transactions. While exploring potential dependencies, we came across the @substrate/txwrapper-dev package, which offers numerous useful functions for our purpose. However, we noticed that it appears in your README under the "non-published" section, although the package is indeed published on npm. This led us to wonder whether it is acceptable to include it as a dependency in our project.

Can you advise us if depending on @substrate/txwrapper-dev is recommended or if we should instead duplicate the relevant parts of the code in our library?

Thank you for your attention, and we look forward to your guidance on this matter.

@TarikGul
Copy link
Member

TarikGul commented Jul 5, 2023

Can you advise us if depending on @substrate/txwrapper-dev is recommended or if we should instead duplicate the relevant parts of the code in our library?

Yea feel free to totally use this package. It was always intended to be a dev package for testing in txwrapper-*, but if you find merit in using it then I would say feel free to use it. I will update the README as this has changed.

That being said there is some drawbacks. One drawback to using txwrapper-dev is you are subject to its releases and updates so if you need things to be iterated on fast for your local dev environment then it could take a few days for a new release to come out.

@EmilIvanichkovv
Copy link
Contributor Author

One drawback to using txwrapper-dev is you are subject to its releases and updates so if you need things to be iterated on fast for your local dev environment then it could take a few days for a new release to come out.

I think it's a trade-off we can accept. Furthermore, since it is an open-source project, we can always contribute to the development work here to ease and fasten the iterations

@TarikGul
Copy link
Member

TarikGul commented Jul 5, 2023

I think it's a trade-off we can accept. Furthermore, since it is an open-source project, we can always contribute to the development work here to ease and fasten the iterations

Awesome, sounds really great :) We are more than happy at doing weekly releases at the beginning of every week as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants