Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example showing how to create a registry with api type defs from type package #45

Closed
emostov opened this issue Jan 12, 2021 · 0 comments · Fixed by #48
Closed

Example showing how to create a registry with api type defs from type package #45

emostov opened this issue Jan 12, 2021 · 0 comments · Fixed by #48
Assignees
@emostov

Comments

@emostov
Copy link
Contributor

emostov commented Jan 12, 2021 •
edited
Loading

Currently, the txwrapper-registry package pulls in type defs from @polkadot/apps-config. While this solution is conveinnt, some chain builders may want to pull in types directly from there own types package.

There should be a showing how to use txwrapper-core's getRegistryBase method and polkadot-js type definitions from a package to create a getRegistry method.
@emostov emostov mentioned this issue Jan 13, 2021
Closed
@emostov emostov self-assigned this Jan 20, 2021
emostov added a commit that referenced this issue Jan 20, 2021
@emostov
feat: Use local getRegistry functions
5506c02 
Closes #47, Closes #46, Closes #45
- Transition packages to use their own getRegistry function in order to decrease deps and supply chain waits for types
- Add a chain builder example for how to create local getRegistry
- remove apps-config dep for txwrapper-orml to reduce package size; replaced with acala types as a dev dep
@emostov emostov mentioned this issue Jan 20, 2021
Merged
emostov added a commit that referenced this issue Jan 21, 2021
@emostov @TarikGul
feat: Use local getRegistry functions (#48)
4c430ba 
* feat: Use local `getRegistry` functions

Closes #47, Closes #46, Closes #45
- Transition packages to use their own getRegistry function in order to decrease deps and supply chain waits for types
- Add a chain builder example for how to create local getRegistry
- remove apps-config dep for txwrapper-orml to reduce package size; replaced with acala types as a dev dep

* Apply suggestions from code review

Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>

* Use 1) for md ordered ls

* Update examle code

* Clean up

* Use ^ versioning

Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emostov emostov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Use local getRegistry functions paritytech/txwrapper-core
1 participant
@emostov