feat: Use local getRegistry functions
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #47, Closes #46, Closes #45 - Transition packages to use their own getRegistry function in order to decrease deps and supply chain waits for types - Add a chain builder example for how to create local getRegistry - remove apps-config dep for txwrapper-orml to reduce package size; replaced with acala types as a dev dep
TarikGul
reviewed
Jan 20, 2021
TarikGul
reviewed
Jan 20, 2021
TarikGul
reviewed
Jan 20, 2021
TarikGul
reviewed
Jan 20, 2021
|
|
||
| /** | ||
| * `ChainProperties` for networks that txwrapper-polkadot supports. These are normally returned | ||
| * by `system_properties` call, but since they don't change much, it's pretty safe to hardcode them. |
There was a problem hiding this comment.
When would the chain properties change? Is that something we would have to take into account in the future?
There was a problem hiding this comment.
So far the only time chain properties has changed on polkadot/ kusama is when Polkadot did a re-denomination from 12 to 10 decimals. I imagine the most common change would be if a chain supported multiple currencies, that might affect the chain properties, just a guess though.
The more I think about this though, I think I should pull this from here and just update the example to fetch the chain properties.
TarikGul
approved these changes
Jan 20, 2021
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47, Closes #46, Closes #45
getRegistryfunction in order to decrease deps and supply chain waits for types.getRegistry.decodefunction tests to be associated with the specific runtime of a chain.