Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update polkadot-js and remove unnecessary dep bloat #288

Merged
merged 3 commits into from
Apr 22, 2023

Conversation

TarikGul
Copy link
Member

Updates the following:

// Deps
"@polkadot/api": "^10.2.1",
"@polkadot/keyring": "^11.1.2",
// Dev deps
"@polkadot/util-crypto": "^11.1.2",
"@types/node-fetch": "^2.6.2",

Removes the following:

"@acala-network/type-definitions": "^0.7.4-1",

@TarikGul TarikGul requested a review from a team as a code owner March 28, 2023 20:05
Copy link
Collaborator

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Tiny notes :

  1. @types/node-fetch has already a new version 2.6.3.
  2. We no longer update lerna dependency since we do not use in the release right ? Maybe we should update the README section also ?
  3. Just confirming that other packages that have new versions like ts-jest, ts-node, tsconfig-paths, typedoc, typescript, etc we update in another PR since this one is pjs deps focused right ?
    Thank you in advance for the feedback!!! 🙏

@TarikGul TarikGul requested a review from a team March 29, 2023 12:10
@TarikGul
Copy link
Member Author

We no longer update lerna dependency since we do not use in the release right ? Maybe we should update the README section also ?

We do still use lerna. But since that is a pretty important dep and has had some breaking changes that should be updated in its own PR.

Just confirming that other packages that have new versions like ts-jest, ts-node, tsconfig-paths, typedoc, typescript, etc we update in another PR since this one is pjs deps focused right ?
Thank you in advance for the feedback!!! 🙏

Similar to Lerna these should not be coupled in this PR and instead its own PR. Just makes it easier on us for debugging etc.

@types/node-fetch has already a new version 2.6.3.

👍

@TarikGul TarikGul merged commit cd92256 into main Apr 22, 2023
@TarikGul TarikGul deleted the tarik-update-pjs branch April 22, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants