Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename state{mint, mine} to asset-hub-* #307

Merged
merged 4 commits into from
Jul 4, 2023
Merged

Conversation

Imod7
Copy link
Collaborator

@Imod7 Imod7 commented Jun 22, 2023

Changes

Following the changes made in the Cumulus PR Rename Statemint to Asset Hub #2633, the following renamings were made in txwrapper-core :

  • statemint -> asset-hub-polkadot/assetHubPolkadot/ASSET_HUB_POLKADOT depending on the instance
  • statemine -> asset-hub-kusama/assetHubKusama/ASSET_HUB_KUSAMA depending on the instance

Exceptions

No renamings were made in :

  1. the statemint and statemint references in this index.ts file
  2. the same in specNameAdjusted in this line
  3. the statemine reference here

Since they all refer to the specName and as mentioned in the PR description this does not change.

@Imod7 Imod7 requested a review from a team as a code owner June 22, 2023 14:15
Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@@ -22,12 +22,14 @@ export function getRegistryStatemine(
},
specTypes: getSpecTypes(
new TypeRegistry(),
'Statemine',
'Asset Hub Kusama',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO things like this make the transition confusing because this is actually not Asset hub Kusama since the metadata passed in does not recognize asset-hub yet. Which means we would need to do 2 PR's that properly change over everything. We should really keep this to what is defined in the metadata, and hold off on having 2 different names here.

My question here would be does getSpecTypes recognize Asset Hub Kusama?

@TarikGul
Copy link
Member

https://github.com/paritytech/txwrapper-core/blob/main/packages/txwrapper-polkadot/src/index.ts#L96-L98

When we look at the above code, we still only recognize statemine, and statemint (You referenced this in your above exceptions). So I think the best way we can approach this is to add asset-hub-kusama, and asset-hub-polkadot in there but don't remove statemine, and statemint so we can have an easier transition.

That way all the specNames are covered.

@TarikGul
Copy link
Member

TarikGul commented Jul 4, 2023

I added asset-hub-kusama, asset-hub-polkadot, and asset-hub-westend to the KNOWN_CHAIN_PROPERTIES inside of txwrapper-polkadot. I also kept statemine, statemint, and westmint to make the transition smooth.

@TarikGul TarikGul merged commit 3a1822a into main Jul 4, 2023
4 checks passed
@TarikGul TarikGul deleted the domi-asset-hub-renaming branch July 4, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants