Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(txwrapper-dev): fix tokenDecimals & ss58Format values of westend registry #311

Merged

Conversation

EmilIvanichkovv
Copy link
Contributor

This change is based on my understanding on the information outlined in the following resource: https://wiki.polkadot.network/docs/learn-DOT#getting-tokens-on-the-westend-testnet.

@TarikGul
Copy link
Member

TarikGul commented Jul 4, 2023

Amazing, thanks so much for the PR. I added an extra suggestion as well as the ss58 format should be 42.

Once the ss58Format is updated as well we can merge this in :)

@EmilIvanichkovv EmilIvanichkovv force-pushed the fix/westend-registry-tokenDecimals branch from c18e2c4 to 7257b3b Compare July 4, 2023 07:33
@EmilIvanichkovv
Copy link
Contributor Author

Thank you! Just added the ss58Format value correction.

@EmilIvanichkovv EmilIvanichkovv changed the title fix(txwrapper-dev): fix tokenDecimals value of westend registry fix(txwrapper-dev): fix tokenDecimals & ss58Format values of westend registry Jul 4, 2023
Copy link
Collaborator

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 💯 Thank you for the quick reaction & PR!

@TarikGul
Copy link
Member

TarikGul commented Jul 4, 2023

Thanks again for the PR!

@TarikGul TarikGul merged commit 5ced6d3 into paritytech:main Jul 4, 2023
4 checks passed
@EmilIvanichkovv EmilIvanichkovv deleted the fix/westend-registry-tokenDecimals branch July 6, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants