fix: prevent error in service worker environment #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidg
changed the title
TarikGul
approved these changes
Jun 19, 2024
|
@chidg Just needs |
|
Thanks for the quick review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Chromium extensions under Manifest Version 3, the project throws an error:
This is because in service workers,
windowis not defined, soisBrowseris false, butprocessis also not defined by default.This could not be fixed by webpack's
DefinePluginbecause of the optional chaining; the optionally-chained expression actually gets transpiled to something quite different in the built package -typeof process?.env?.TXWRAPPER_METADATA_CACHE_MAX !== 'undefined'becomestypeof ((_a = process === null || process === void 0 ? void 0 : process.env) === null || _a === void 0 ? void 0 : _a.TXWRAPPER_METADATA_CACHE_MAX) !== 'undefined', whichDefinePlugincan't parse.Currently in Talisman as we transition to MV3 we're dealing with this by monkey patching a
processglobal variable into the service worker, however we'd like to avoid this if possible.