Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mccalluc/travis fast fail #1423

Merged
merged 4 commits into from
Sep 27, 2016
Merged

Mccalluc/travis fast fail #1423

merged 4 commits into from
Sep 27, 2016

Conversation

mccalluc
Copy link
Member

  • The first commit fails in the expected manner
  • The second commit gets through all the tests, and then fails on codecov:
$ npm run codecov
ERR! Error: ENOENT, open '/home/travis/build/parklab/refinery-platform/refinery/package.json'

Looking at an earlier travis run which did complete successfully, I see the same error near the end of the full log, but it kept on going: https://travis-ci.org/parklab/refinery-platform/builds/162217766 for example.

  • In the last commit, I add set +e at the end of the script section, and it passes ... but maybe we do want to know about errors after the script?

@jkmarx : Does this look ok?

@mccalluc mccalluc merged commit f28a3c2 into develop Sep 27, 2016
@mccalluc mccalluc deleted the mccalluc/travis-fast-fail branch September 27, 2016 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant