-
Notifications
You must be signed in to change notification settings - Fork 138
/
check_isxxx.t
81 lines (61 loc) · 1.62 KB
/
check_isxxx.t
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
#! perl
# Copyright (C) 2006-2009, Parrot Foundation.
# $Id$
use strict;
use warnings;
use lib qw( . lib ../lib ../../lib );
use Test::More tests => 1;
use Parrot::Distribution;
use Parrot::Test::Util::Runloop;
=head1 NAME
t/codingstd/check_isxxx.t - checks that the isxxx() functions are passed
unsigned char
=head1 SYNOPSIS
# test all files
% prove t/codingstd/check_isxxx.t
# test specific files
% perl t/codingstd/check_isxxx.t src/foo.c include/parrot/bar.h
=head1 DESCRIPTION
Checks all C language files to make sure that arguments to the isxxx()
functions are explicitly cast to unsigned char.
=head1 SEE ALSO
L<docs/pdds/pdd07_codingstd.pod>
=cut
my $DIST = Parrot::Distribution->new;
my @files = @ARGV ? <@ARGV> : $DIST->get_c_language_files();
my @no_explicit_cast;
my @isxxx_functions_list = qw(
isalnum
isalpha
isblank
iscntrl
isdigit
isgraph
islower
isprint
ispunct
isspace
isupper
);
my $isxxx_functions = join '|', @isxxx_functions_list;
sub check_isxxx {
my $line = shift;
# does the line contain an isxxx call?
return 1 unless $line =~ /[^_]($isxxx_functions)\([^)]+/;
# is the line missing a cast?
return 1 unless $line !~ /[^_]($isxxx_functions)\(\(unsigned char\)/;
# yes! fail.
return 0;
}
Parrot::Test::Util::Runloop->testloop(
name => 'isxxx() functions cast correctly',
files => [@files],
per_line => \&check_isxxx,
diag_prefix => 'isxxx() function not cast to unsigned char'
);
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 100
# End:
# vim: expandtab shiftwidth=4: