-
Notifications
You must be signed in to change notification settings - Fork 138
/
warnings.pm
497 lines (420 loc) · 14.4 KB
/
warnings.pm
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
# Copyright (C) 2007-2014, Parrot Foundation.
=head1 NAME
config/auto/warnings.pm - Warning flags probing.
=head1 DESCRIPTION
Given a list of potential warnings available for a certain type of
compiler, probe to see which of those are valid for this particular version.
=over 4
=cut
package auto::warnings;
use strict;
use warnings;
use base qw(Parrot::Configure::Step);
use Parrot::Configure::Utils ();
use Parrot::BuildUtil;
=item C<_init>
Declare potential warnings for various compilers. Note that the compiler
key used here doesn't really exist in a unified way in Configure - would
be nice if it did so we could simplify our checks in runstep().
We create a data structure here that breaks out the warnings by compiler,
using this structure:
warnings:
gcc:
basic:
- -Warning1
- -Warning2
cage:
- -Warning3
- -Warning4
only:
- -Warning5:
- foo.c
- bar.c
never:
- -Warning6:
- baz.c
- frob.c
todo:
- -Warning7:
- cow.c
- pig.c
g++:
...
'basic' warnings are always used.
'cage' warnings are added only if --cage is specified during
Configure. This can be used to hold warnings that aren't ready to be
added to the default run yet.
'only' should be used as we add new warnings to the build, it will let
us ensure that files we know are clean for a new warning stay clean.
'never' should be used when a particular file contains generated code
(e.g. imcc) and we cannot update it to conform to the standards.
'todo' functions just like never does, but it indicates that these
files are expected to eventually be free of this warning.
'override' adds warnings to the end, to override previous warnings enabled
by -Wall or -Wextra for example.
Note that there is no actual requirement that the 'file' be a full path
to a .c file; the file could be "PMCS" or "OPS" or some other identifier;
whatever the value, it will generate a Config entry prefixed with
C<ccwarn::>, which will be used via @@ expansion in a makefile.
It is tempting to put this into a config file, but having it in
perl gives us the ability to dynamically setup certain warnings based
on any criteria already discovered via Config.
Order is important - some warnings are invalid unless they are specified
after other warnings.
=cut
sub _init {
my $self = shift;
my $data = {
description => 'Detect supported compiler warnings',
result => '',
validated => [],
};
# begin gcc/g++
my $gcc = {};
my $gpp = {};
my $icc = {};
# man gcc
# -Wall contains:
# -Waddress -Warray-bounds (only with -O2) -Wc++0x-compat -Wchar-subscripts
# -Wenum-compare (in C/Objc; this is on by default in C++) -Wimplicit-int (C and
# Objective-C only) -Wimplicit-function-declaration (C and Objective-C only) -Wcomment
# -Wformat -Wmain (only for C/ObjC and unless -ffreestanding) -Wmissing-braces -Wnonnull
# -Wparentheses -Wpointer-sign -Wreorder -Wreturn-type -Wsequence-point -Wsign-compare
# (only in C++) -Wstrict-aliasing -Wstrict-overflow=1 -Wswitch -Wtrigraphs
# -Wuninitialized -Wunknown-pragmas -Wunused-function -Wunused-label -Wunused-value
# -Wunused-variable -Wvolatile-register-var
# -Wextra contains:
# -Wclobbered -Wempty-body -Wignored-qualifiers -Wmissing-field-initializers
# -Wmissing-parameter-type (C only) -Wold-style-declaration (C only) -Woverride-init
# -Wsign-compare -Wtype-limits -Wuninitialized -Wunused-parameter (only with -Wunused or
# -Wall) -Wunused-but-set-parameter (only with -Wunused or -Wall)
my @gcc_or_gpp_basic = qw(
-fpermissive
-falign-functions=16
-funit-at-a-time
-fexcess-precision=standard
-maccumulate-outgoing-args
-Wall
-Wextra
-Waggregate-return
-Wcast-qual
-Wdisabled-optimization
-Wdiv-by-zero
-Wendif-labels
-Wno-format
-Wimplicit
-Wimport
-Winit-self
-Winline
-Winvalid-pch
-Wjump-misses-init
-Wlogical-op
-Werror=missing-braces
-Werror=missing-declarations
-Wno-missing-format-attribute
-Wmissing-include-dirs
-Wmultichar
-Wpacked
-Wpointer-arith
-Wreturn-type
-Wsequence-point
-Wsign-compare
-Wstrict-aliasing
-Wstrict-aliasing=2
-Wswitch
-Wswitch-default
-Werror=undef
-Wno-unused
-Wvariadic-macros
-Wwrite-strings
-Wstack-usage=500
);
# gcc-only warnings that would break g++
my @gcc_basic = qw(
-Wc++-compat
-Werror=declaration-after-statement
-Werror=implicit-function-declaration
-Werror=missing-prototypes
-Werror=nested-externs
-Werror=old-style-definition
-Werror=strict-prototypes
);
$gcc->{'basic'} = [ @gcc_or_gpp_basic, @gcc_basic ];
$gpp->{'basic'} = [ @gcc_or_gpp_basic ];
my @gcc_or_gpp_cage = qw(
-std=c89
-Wfloat-equal
-Wformat-extra-args
-Wformat-nonliteral
-Wformat-security
-Wformat-y2k
-Wformat=2
-Wlarger-than-4096
-Wmissing-format-attribute
-Wdeprecated-declarations
-Wno-import
-Wredundant-decls
-Wshadow
-Wstrict-overflow=5
-Wsuggest-attribute=const
-Wsuggest-attribute=noreturn
-Wsuggest-attribute=returns_nonnull
-Wsuggest-attribute=pure
-Wsuggest-attribute=warn_unused_result
-Wsuggest-attribute=hot
-Wtrampolines
-Wunreachable-code
-Wunsafe-loop-optimizations
-Wunused
-Wunused-function
-Wunused-label
-Wunused-value
-Wunused-variable
-Wvolatile-register-var
);
my @gpp_cage = qw(
-Weffc++
-Wstrict-null-sentinel
-Wtraditional
-Wuseless-cast
);
$gcc->{'cage'} = [ @gcc_or_gpp_cage ];
$gpp->{'cage'} = [ @gcc_or_gpp_cage, @gpp_cage ];
# strip from the list
$gcc->{'todo'} = $gpp->{'todo'} = {
'-Wformat-nonliteral' => [ qw(
src/string/spf_render.c
src/io/api.c
src/exit.c
compilers/imcc/optimizer.c
) ],
'-Wstrict-prototypes' => [ qw(
src/nci/extra_thunks.c
src/extra_nci_thunks.c
) ],
};
# strip from the list
$gcc->{'never'} = $gpp->{'never'} = {
'-Wformat-nonliteral' => [ qw(
compilers/imcc/imclexer.c
) ],
'-Wswitch-default' => [ qw(
compilers/imcc/imclexer.c
compilers/imcc/imcparser.c
) ],
'-Wcast-qual' => [ qw(
compilers/imcc/imcparser.c
) ],
'-Wsign-compare' => [ qw(
compilers/imcc/imclexer.c
compilers/imcc/imcparser.c
) ],
};
# add at the end
$gcc->{'override'} = $gpp->{'override'} = {
'-Wno-unused-result' => [ qw(
src/ops/core_ops.c
) ],
};
# Warning flags docs
# http://software.intel.com/sites/products/documentation/hpc/compilerpro/en-us/cpp/lin/compiler_c/index.htm
$icc->{'basic'} = [ qw(
-w2
-Wabi
-Wall
-Wcheck
-Wcomment
-Wdeprecated
-Weffc++
-Wextra-tokens
-Wformat
-Wformat-security
-Wmain
-Wmaybe-uninitialized
-Wmissing-declarations
-Wmissing-prototypes
-Wpointer-arith
-Wport
-Wshadow
-Wstrict-prototypes
-Wuninitialized
-Wunknown-pragmas
-Wunused-function
-Wunused-variable
-Wwrite-strings
),
# Disable some warnings and notifications that are overly noisy
'-diag-disable 271', # trailing comma is nonstandard
'-diag-disable 981', # operands are evaluated in unspecified order
'-diag-disable 1572', # floating-point equality and inequality comparisons are unreliable
'-diag-disable 2259', # non-pointer conversion from "typeA" to "typeB" may lose significant bits
];
$icc->{'cage'} = [
# http://software.intel.com/sites/products/documentation/hpc/compilerpro/en-us/cpp/lin/compiler_c/bldaps_cls/common/bldaps_svover.htm
'-diag-enable sc3',
'-diag-enable sc-include',
];
$data->{'warnings'}{'gcc'} = $gcc;
$data->{'warnings'}{'g++'} = $gpp;
$data->{'warnings'}{'icc'} = $icc;
$data->{'warnings'}{'clang'} = $gcc;
$data->{'warnings'}{'clang'}->{'cage'} = [ @gcc_or_gpp_cage, '-Wcast-align' ];
$data->{'warnings'}{'clang'}->{'override'} = {
'-Wno-format-nonliteral' => [ qw(
src/string/sprintf.c
src/string/spf_render.c
) ],
'-Wno-unused-parameter' => [ qw(
compilers/imcc/imclexer.c
src/dynoplibs/math_ops.c
) ],
'-Wno-sign-compare' => [ qw(
compilers/imcc/imclexer.c
compilers/imcc/imcparser.c
) ],
};
## end gcc/g++
return $data;
}
sub runstep {
my ( $self, $conf ) = @_;
$conf->debug("\n");
my $compiler = '';
if ( defined $conf->data->get('gccversion') ) {
$compiler = $conf->data->get('g++') ? 'g++' :
$conf->data->get('clang') ? 'clang' : 'gcc';
}
elsif ( $conf->option_or_data('cc') =~ /icc/ ) {
$compiler = 'icc';
}
if ($compiler eq '') {
$conf->debug("We do not (yet) probe for warnings for your compiler\n");
$self->set_result('skipped');
return 1;
}
if (
( $compiler eq 'gcc' or $compiler eq 'g++' ) and
( $conf->data->get('gccversion') >= 4.0 )
) {
push @{$self->{'warnings'}{$compiler}{'basic'}},
'-fvisibility=hidden';
};
# cygwin gcc is more particular about -fpermissive in c mode.
# this is the 1st element
if ( $^O eq 'cygwin' and $compiler eq 'gcc' and
$conf->data->get('gccversion') >= 4.0 ) {
shift @{$self->{'warnings'}{'gcc'}{'basic'}};
};
# icu4.2 -4.9 uset.h had a wrong uset_openEmpty() declaration missing (void) GH #867
my $icu_version = $conf->data->get('icu_version');
if ($icu_version and $icu_version >= 42.0 and $icu_version < 50.1) {
$self->{'warnings'}{$compiler}{'never'}{'-Werror=strict-prototypes'} =
[ 'src/string/encoding/shared.c' ];
}
if ($conf->data->get('clang') and $compiler eq 'g++') { # clang++
$self->{'warnings'}{'g++'}{'override'} =
$self->{'warnings'}{'clang'}->{'override'};
}
# standard warnings.
my @warnings = grep {$self->valid_warning($conf, $_)}
@{$self->{'warnings'}{$compiler}{'basic'}};
# --cage?
if ($conf->options->get('cage')) {
push @warnings, grep {$self->valid_warning($conf, $_)}
@{$self->{'warnings'}{$compiler}{'cage'}};
}
# -- only?
my %per_file;
if (exists $self->{'warnings'}{$compiler}{'only'}) {
my %only = %{$self->{'warnings'}{$compiler}{'only'}};
foreach my $warning (keys %only) {
next unless $self->valid_warning($conf, $warning);
foreach my $file (@{$only{$warning}}) {
$per_file{$file} = [ @warnings ] unless exists $per_file{$file};
push @{$per_file{$file}}, $warning;
}
}
}
foreach my $key (qw/todo never/) {
if (exists $self->{'warnings'}{$compiler}{$key}) {
my %dont = %{$self->{'warnings'}{$compiler}{$key}};
foreach my $warning (keys %dont) {
foreach my $file (@{$dont{$warning}}) {
$per_file{$file} = [ @warnings ] unless exists $per_file{$file};
@{$per_file{$file}} = grep {$warning ne $_} @{$per_file{$file}};
}
}
}
}
if (exists $self->{'warnings'}{$compiler}{override}) {
my %add = %{$self->{'warnings'}{$compiler}{override}};
foreach my $warning (keys %add) {
if ($self->valid_warning($conf, $warning)) {
foreach my $file (@{$add{$warning}}) {
$per_file{$file} = exists $per_file{$file}
? [ @{$per_file{$file}}, $warning ] : [ @warnings, $warning ];
}
}
}
}
$conf->data->set('ccwarn', join(' ', @warnings));
foreach my $file (keys %per_file) {
$conf->data->set("ccwarn::$file", join(' ', @{$per_file{$file}}));
}
$self->set_result('done');
return 1;
}
=item C<valid_warning>
Try a given warning to see if it is supported by the compiler. The compiler
is determined by the C<cc> value of the C<Parrot::Configure> object passed
in as the first argument to the method (not counting C<$self>. The warning
to be checked is passed in as the second argument to the method.
Returns true if the warning flag is recognized by the compiler and undef
otherwise.
Use the running set of known valid options, since some options may depend
on previous options.
=cut
sub valid_warning {
my ( $self, $conf, $warning ) = @_;
# This should be using a temp file name.
my $output_file = 'test.cco';
$conf->debug("trying warning '$warning'\n");
my $cc = $conf->data->get('cc');
$conf->cc_gen('config/auto/warnings/test_c.in');
my $ccflags = $conf->data->get('ccflags');
my $warnings = join(' ', @{$self->{'validated'}});
my $tryflags = "$ccflags $warnings $warning";
my $command_line = Parrot::Configure::Utils::_build_compile_command( $cc, $tryflags );
$conf->debug(" ", $command_line, "\n");
# Don't use cc_build, because failure is expected.
my $exit_code = Parrot::Configure::Utils::_run_command(
$command_line, $output_file, $output_file
);
# Cleanup any remnants of the test compilation
$conf->cc_clean();
if ($exit_code) {
unlink $output_file or die "Unable to unlink $output_file: $!";
return;
}
my $output = Parrot::BuildUtil::slurp_file($output_file);
unlink $output_file or die "Unable to unlink $output_file: $!";
$conf->debug(" output: $output\n");
if ( $output !~ /\berror|warning|not supported|ignoring (unknown )?option\b/i ) {
push @{$self->{'validated'}}, $warning;
$conf->debug(" valid warning: '$warning'\n");
return 1;
}
else {
$conf->debug(" invalid warning: '$warning'\n");
return 0;
}
}
=back
=cut
1;
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 100
# End:
# vim: expandtab shiftwidth=4: